Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grid): display multiple forms in a grid #1414

Closed
2 of 5 tasks
DevinWalker opened this issue Jan 20, 2017 · 20 comments
Closed
2 of 5 tasks

feat(grid): display multiple forms in a grid #1414

DevinWalker opened this issue Jan 20, 2017 · 20 comments
Assignees

Comments

@DevinWalker
Copy link
Member

DevinWalker commented Jan 20, 2017

Issue Overview

We should have a [donation_form_grid] shortcode that display donation forms in a nice layout:
grid

Grid Element Explanation

2017-01-20_21-58-57

Shortcode Attributes

  • number: Default = 3
  • goal (if applicable): Default = true
  • excerpt: Default = true
  • featured_image : Default = true

Acceptance Criteria

  • Grid should fill full width of container
  • Grid should be responsive
  • Grid should have minimal conflict with themes

Tasks

  • Design Grid
  • Develop Shortcode
  • Implement CSS Grid
  • Test with Popular Themes (Avada, Divi, X, etc)
  • Documentation
@DevinWalker DevinWalker added this to the 2.0 milestone Jan 20, 2017
@DevinWalker DevinWalker self-assigned this Jan 20, 2017
@mathetos
Copy link
Member

This sounds like an Add-on to me, not a Core feature.

@DevinWalker
Copy link
Member Author

DevinWalker commented Jan 20, 2017 via email

@mathetos
Copy link
Member

@DevinWalker I think there's overlap here with issue #1230

What do you think of moving this issue to be a feature of #1230 Basically, the [give_forms] shortcode proposed in #1230 could have a display_style attribute as follows:

  • [give_forms id="all" display_style="grid"]
  • [give_forms id="5,6,7" display_style="list"]

@Benunc
Copy link
Member

Benunc commented Oct 11, 2017

Adding a "category" or "tag" parameter to this shortcode would be powerful, as well. Users have requested this. (one today)

@ravinderk ravinderk modified the milestones: 2.0, 1.8.15 Oct 17, 2017
@khan19
Copy link

khan19 commented Oct 17, 2017

Hello,

Are these shortcodes ready to use? I have used them on Avada theme. It didn't work.

Thanks,
Mazhar

@ravinderk
Copy link
Collaborator

@khan19 We are working on this and it will work on next release (1.8.15).

@khan19
Copy link

khan19 commented Oct 17, 2017

Alright, Thank you :) Good wishes for next release!

@mehul0810
Copy link
Contributor

@DevinWalker I've tried to build the [donation_form_grid] shortcode. But, It seems that with current structure of donation forms. It will require to break lots of code related to donation forms and duplication of code as well.
Also, If we build it now then we need to test the main functionality donation form as well and refactoring the donation forms and the shortcodes again when we release the Form API (i.e. #1038).

I had the discussion for the same with @ravinderk and came to a conclusion that we should bump this issue after Form API so that we can work systematically with out any break and duplication of code.

Even, I've saved the WIP for this issue so that I can re-use it again. (Ref: https://github.com/mehul0810/Give/tree/issue/1414)

Let me know your thoughts.

@DevinWalker
Copy link
Member Author

@mehul0810 I was thinking that rather than loading the structure of the donation form within each grid item that you could simply create your own structure and the "Donate Now" button would either:

A. Load the donation form in a modal via AJAX
B. Take the donor to the single donation form page

This will allow you to control the markup of the grid within the shortcode and you wouldn't be tied to the form structure. Let me know what you think and we can discuss.

@raftaar1191
Copy link
Contributor

raftaar1191 commented Nov 2, 2017

I also think the same @DevinWalker

We can create our own structure than redirecting link to the single page this sounds good and simple too I guess.

@DevinWalker DevinWalker modified the milestones: 1.8.17, 2.0 Nov 18, 2017
@ravinderk ravinderk modified the milestones: 2.0, 2.1 Nov 27, 2017
@amjad
Copy link

amjad commented Jan 31, 2018

I think the modal popup may not work very well on mobile devices. Its better to have it redirect to its own page. This is definitely a missing feature! Pretty sure many users have multiple forms and it gets hard not being able to show them all in one page in this nice grid layout. We have several clients already waiting for this feature!

What's the status on this?

@mehul0810
Copy link
Contributor

We can create a Gutenberg block for this shortcode and we can add the shortcode attributes in the presentation layout of Gutenberg which can be helpful for end user as discussed with @DevinWalker over call on Friday.

@raftaar1191
Copy link
Contributor

yes @mehul0810 but there will be other user as well who are not going to install the Gutenberg as there default editor

@DevinWalker DevinWalker removed this from the 2.1 milestone Mar 6, 2018
ravinderk added a commit that referenced this issue Mar 9, 2018
feat(donation-grid): Donation form grid display option #1414
@kevinwhoffman kevinwhoffman changed the title Donation form grid display option feat(form): display multiple forms in a grid Mar 13, 2018
@ravinderk
Copy link
Collaborator

@Sidsector9 Can you recreate a pr for this issue because the last pr merged into WordImpress:feature/gutenberg-donation-form-block which is Gutenberg block specific which is not a priority for 2.1.

@amjad
Copy link

amjad commented Mar 13, 2018

will this be a part of 2.1 ?

@ravinderk
Copy link
Collaborator

@amjad Yes.
If you need more information about 2.1 release planning then you can check this link: https://github.com/WordImpress/Give/wiki/Give-Release-Planning

@amjad
Copy link

amjad commented Mar 13, 2018

Awesome, thanks!

@kevinwhoffman
Copy link
Contributor

@Sidsector9 After discussing with @DevinWalker, I am going to work with you to get CSS Grid implemented in the Donation Form Grid prior to release. We want to make sure CSS Grid is our grid solution moving forward.

@Sidsector9
Copy link
Contributor

@kevinwhoffman Are we focusing to implement Grid for just Donation Form Grid or the entire Give plugin?

@kevinwhoffman kevinwhoffman removed their assignment Mar 22, 2018
@kevinwhoffman kevinwhoffman changed the title feat(form): display multiple forms in a grid feat(grid): display multiple forms in a grid Mar 22, 2018
@kevinwhoffman
Copy link
Contributor

Closing in favor of #2943 which picks up where this issue left off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants