Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link missing in All Donation Page when there is no donation #2263

Closed
2 tasks
raftaar1191 opened this issue Oct 30, 2017 · 5 comments
Closed
2 tasks

Link missing in All Donation Page when there is no donation #2263

raftaar1191 opened this issue Oct 30, 2017 · 5 comments
Assignees
Milestone

Comments

@raftaar1191
Copy link
Contributor

Issue Overview

It should have a link where admin can Import Donation the same when we have some donation there

All Donation Page ( When we have zero Donation ):
image

All Donation Page ( When we have at least one Donation )
image

Expected Behavior

Should have link to Import Donation and it should also support addon as well

Current Behavior

No Link can be found

Steps to Reproduce (for bugs)

  1. Delete all the donation or set up a new site completely
  2. Go to All donation page you will see the error

Todos

  • Tests
  • Documentation
@kevinwhoffman
Copy link
Contributor

Good catch @raftaar1191. I believe the New Donation button is only available when Manual Donations add-on is installed. We should make sure both New Donation and Import Donations buttons are accessible even if no donations exist.

@raftaar1191
Copy link
Contributor Author

Yes @kevinwhoffman you are right New Donation Manual Donations add-on is installed

@kevinwhoffman
Copy link
Contributor

Quick fix would be to remove .page-title-action from this line so that it is not hidden on the blank slate screens.

https://github.com/WordImpress/Give/blob/6f8d05b1528e412e9809fad47db7bc227e96b255/includes/admin/class-blank-slate.php#L193

The original intent was to simplify the UI by having a singular call to action in the blank slate, but obviously we need something more flexible.

@DevinWalker
Copy link
Member

Good catch @raftaar1191 - since this is a simple fix as @kevinwhoffman outlined I'm including this in 1.8.17.

@raftaar1191
Copy link
Contributor Author

raftaar1191 commented Nov 7, 2017

Sure @DevinWalker

Thanks @kevinwhoffman for the quick solutions

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Nov 7, 2017
raftaar1191 added a commit to raftaar1191/Give that referenced this issue Nov 7, 2017
raftaar1191 added a commit to raftaar1191/Give that referenced this issue Nov 7, 2017
@raftaar1191 raftaar1191 mentioned this issue Nov 7, 2017
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants