Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues 2263 #2302

Merged
merged 3 commits into from
Nov 7, 2017
Merged

Conversation

raftaar1191
Copy link
Contributor

Description

PR for issues #2263

How Has This Been Tested?

Test the layout with the donation in it and also after deleting all the donation within it and with the Add-on as well

Screenshots (jpeg or gifs if applicable):

image

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@raftaar1191
Copy link
Contributor Author

@ravinderk @DevinWalker

Please review & merge the PR request

@ravinderk
Copy link
Collaborator

@raftaar1191 @kevinwhoffman I am getting weird button on empty form listing

screen shot 2017-11-07 at 8 28 49 pm

@DevinWalker DevinWalker merged commit e55e430 into impress-org:release/1.8.17 Nov 7, 2017
@raftaar1191
Copy link
Contributor Author

@ravinderk

I tried this with old as well as by creating new instance but was not able to regenerate the issues

I have also checked the URL that you send it with the screenshot
image

I have also check with the diff-diff version of WordPress Core from 4.8 to 4.8.3.
I have also check with the Give Add-on as well as without the Give Add-on

@ravinderk
Can you try to regenerate the issues on another site and as well the step from which you are deleting the Donation Form

@kevinwhoffman
Copy link
Contributor

The Empty Trash button only appears when there is a form in the trash, so you'll likely need to create a form and then trash it to recreate the issue. Then look at the CSS class used to wrap the button and add it to the list of classes that are hidden.

@raftaar1191
Copy link
Contributor Author

Thanks @kevinwhoffman I will check that too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants