Poupup in not opening for Modal and Button display type

[jaydeeprami]

Issue Overview

• Donation popup not working for 'Modal' and 'Button' display type.

Expected Behavior

• Popup should open for both (Modal' and 'Button').

Current Behavior

• Popup not working for the Modal and Button display type when clicking on the Donate now button.

Possible Solution

Steps to Reproduce (for bugs)

1. Create new Form
2. Choose Display option type 'Modal' or 'Button'
3. Go to Frontend, Click on 'Donate Now' button
4. As you can see, Popup is not open.

Related Issues and/or PRs

Todos

• Tests

WordPress Environment

``` ### WordPress Environment ###

Home URL: http://givewp.dev
Site URL: http://givewp.dev
WP Version: 4.9
WP Multisite: –
WP Memory Limit: 256 MB
WP Debug Mode: ✔
WP Cron: ✔
Language: en_US
Permalink Structure: /%year%/%monthnum%/%day%/%postname%/
Show on Front: posts
Table Prefix Length: 3
Table Prefix Status: Acceptable
Admin AJAX: Inaccessible
Registered Post Statuses: publish, future, draft, pending, private, trash, auto-draft, inherit, refunded, failed, revoked, cancelled, abandoned, processing, preapproval

Server Environment

Hosting Provider: DBH: localhost, SRV: givewp.dev
TLS Connection:
TLS Connection:
Server Info: nginx/1.10.1
PHP Version: 7.1.4
PHP Post Max Size: 1,000 MB
PHP Time Limit: 900
PHP Max Input Vars: 3000
PHP Max Upload Size: 1,000 MB
cURL Version: ❌ 7.38.0, OpenSSL/1.0.1t - We recommend a minimum cURL version of 7.40.
SUHOSIN Installed: –
MySQL Version: ❌ 5.5.55 - We recommend a minimum MySQL version of 5.6. See: WordPress Requirements
Default Timezone is UTC: ✔
fsockopen/cURL: ✔
SoapClient: ✔
DOMDocument: ✔
gzip: ✔
GD Graphics Library: ✔
Multibyte String: ✔
Remote Post: ❌ wp_remote_post() failed. PayPal IPN won't work with your server. Contact your hosting provider. Error: cURL error 28: Resolving timed out after 10530 milliseconds
Remote Get: ❌ wp_remote_get() failed. The Give plugin updater won't work with your server. Contact your hosting provider. Error: cURL error 28: Resolving timed out after 5518 milliseconds

Give Configuration

Give Version: 1.8.17
Upgraded From: –
Test Mode: Enabled
Currency Code: USD
Currency Position: Before
Decimal Separator: .
Thousands Separator: ,
Success Page: http://givewp.dev/donation-confirmation/
Failure Page: http://givewp.dev/donation-failed/
Donation History Page: http://givewp.dev/donation-history/
Give Forms Slug: /donations/
Enabled Payment Gateways: Test Donation, Offline Donation, PayPal Standard
Default Payment Gateway: Test Donation
PayPal IPN Verification: Enabled
PayPal IPN Notifications: N/A
Admin Email Notifications: Enabled
Donor Email Access: Enabled

Session Configuration

Give Use Sessions: Enabled
Session: Disabled

Active Give Add-ons

Other Active Plugins

Inactive Plugins

Give - Currency Switcher: by WordImpress – 1.0.0
Give - Fee Recovery: by WordImpress – 1.3
Give - Form Field Manager: by WordImpress – 1.2.3
Give - Gift Aid: by WordImpress – 1.0.0
Give - PDF Receipts: by WordImpress – 2.1
Give - Recurring Donations: by WordImpress – 1.4
Give - Setting API Fields Example: by WordImpress – 1.0
Give - Stripe Gateway: by WordImpress – 1.5
Give - Tributes: by WordImpress – 1.2

Active MU Plugins

Local by Flywheel Relative URL (for Live Links): by Flywheel – 1.0

Theme

Name: Twenty Seventeen
Version: 1.3
Author URL: https://wordpress.org/
Child Theme: No – If you're modifying Give on a parent theme you didn't build personally, then we recommend using a child theme. See: How to Create a Child Theme

</details>

[ravinderk]

@raftaar1191 Can you reproduce this?

[raftaar1191]

Yes @ravinderk I am able to regenerate the issues

The reason is Donation Amount is not Set

Example: Donation Form with Multi-level Form

Example: Donation Form with Set Donation Amount Selected

[DevinWalker]

@raftaar1191 please process with basic amount validation:

1. If form is published as Set Donation and Set Donation is 0 then set to 1.
2. If form is published as Multi-level Donation and all levels are 0 then set to 1.

[raftaar1191]

Okay @DevinWalker doing that

[raftaar1191]

@ravinderk

Still able to reproduce the issues
Please see the video for more information: http://screencast-o-matic.com/watch/cblf0H2g6X

[ravinderk]

@raftaar1191 This issue has been fixed. Please try to reproduce this with latest 1.8.17.
For ref: d079033...52b25b0

[raftaar1191]

@ravinderk As we have discussed on call

This comment issues is not valid

Slack Conversation : https://givewp.slack.com/archives/C0FAGC83C/p1512640487000019