Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[give_receipt] attributes do not work as expected #267

Closed
5 tasks done
mathetos opened this issue Sep 18, 2015 · 3 comments
Closed
5 tasks done

[give_receipt] attributes do not work as expected #267

mathetos opened this issue Sep 18, 2015 · 3 comments
Assignees
@DevinWalker
Milestone
1.3.1

Comments

@mathetos
Copy link
Member

The following attributes do not work as expected. They each show on the receipt regardless of adding them as true/false

  • price
  • date
  • payment_key
  • payment_method
  • payment_id
@mathetos mathetos added this to the 1.4 Milestone milestone Sep 18, 2015
@mathetos
Copy link
Member Author

Tested locally, on latest from Github (not repo version 1.2). Did a test donation to view receipt. Changed the attributes then did another test donation. All while logged in. Didn't test from the email receipt link.

@DevinWalker DevinWalker modified the milestones: 1.3.1, 1.4 Milestone Oct 7, 2015
@DevinWalker
Copy link
Member

Bumped up to 1.3.1 milestone

DevinWalker pushed a commit that referenced this issue Oct 14, 2015
Give shortcode attributes updated to work as expected
cb6bf2b 
Issue was the shortcode builder passing true/false as strings rather than bool

#267
@DevinWalker DevinWalker mentioned this issue Oct 15, 2015
Closed
@mathetos
Copy link
Member Author

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DevinWalker DevinWalker

Labels
None yet
Projects
None yet
Milestone
1.3.1
Development

No branches or pull requests
2 participants
@mathetos @DevinWalker