Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(admin-tool): clarify donor export settings #2964

Closed
kevinwhoffman opened this issue Mar 28, 2018 · 5 comments
Closed

fix(admin-tool): clarify donor export settings #2964

kevinwhoffman opened this issue Mar 28, 2018 · 5 comments
Assignees
@raftaar1191
Milestone
Sprint: 2018/03/2...

Comments

@kevinwhoffman
Copy link
Contributor

kevinwhoffman commented Mar 28, 2018 •
edited

User Story

As an admin, I want to clearly understand what a "donor export" means so that I can retrieve the data I need.

Current Behavior

I currently am confused when interpreting donor export data from all forms vs. a single form. Donation Form is particularly confusing since donors only appear once throughout the donor export.

Expected Behavior

I expect to clearly understand what data I am exporting and viewing.

Possible Solution

See #2964 (comment)

Related

Tasks

See #2964 (comment)
@kevinwhoffman kevinwhoffman added this to the Sprint: 2018/03/28 - 2018/04/10 milestone Mar 28, 2018
@kevinwhoffman kevinwhoffman mentioned this issue Mar 28, 2018
Closed
@raftaar1191
Copy link
Contributor

@kevinwhoffman @mehul0810

I am working on the similarity issues like above one can you please have a look at this issues

Issues Link: #2875

@DevinWalker DevinWalker assigned raftaar1191 and unassigned mehul0810 Mar 29, 2018
@kevinwhoffman
Copy link
Contributor Author

@raftaar1191 I've simplified your tasks on this issue since we are handling the export functionality in #2875. All you have to do here is update Donation Form to First Donation Form in the Donor export.

@raftaar1191 raftaar1191 mentioned this issue Mar 29, 2018
Closed
10 tasks
@raftaar1191
Copy link
Contributor

Hey, @kevinwhoffman did not get you clearly. So just to confirm the above comment that you have made do you want to pre-select the Donation Form fields to first Donation Form in donor export section?

image

@kevinwhoffman
Copy link
Contributor Author

kevinwhoffman commented Mar 30, 2018 •
edited by raftaar1191

Slack Call Summary

Participants: @raftaar1191 @kevinwhoffman
Topic: Clarify the changes to Donor export options
Result: We both agreed that Donation Form is a confusing column to include because each donor only appears once in the donor export (it is a unique list of donors). That means only the first Donation Form would be shown in the export, which is not clear. See below for changes.

image

Updated Tasks

  • Update the setting name and description as follows:
    • Setting Name: Export Donors
    • Description: Download a CSV of donors. Column values reflect totals across all donation forms by default, or a single donation form if selected.
  • Remove the Donation Form checkbox control and CSV column.
  • Rename First Donation Date to Donor Created Date in checkbox control and CSV column.
  • Name the generated CSV file as follows:
    • If "All Forms" are selected, name it give-export-donors-all-forms-03-30-2018.csv
    • If one form is selected, name it give-export-donors-{form-slug}-03-30-2018.csv

@kevinwhoffman kevinwhoffman changed the title feat(admin-tool): export donation history per form fix(admin-tool): clarify donor export settings Mar 30, 2018
raftaar1191 added a commit to raftaar1191/Give that referenced this issue Apr 2, 2018
@raftaar1191
refactor(admin-tool): refactor export donors html impress-org#2964
6a03ec9
raftaar1191 added a commit to raftaar1191/Give that referenced this issue Apr 2, 2018
@raftaar1191
dep(admin-tool): remove donation form colums from CSV impress-org#2964
9e4d6d3
raftaar1191 added a commit to raftaar1191/Give that referenced this issue Apr 2, 2018
@raftaar1191
refactor(admin-tool): change column name in CSV and checkbox impress-…
d5445ba 
…org#2964
raftaar1191 added a commit to raftaar1191/Give that referenced this issue Apr 2, 2018
@raftaar1191
feat(admin-tool): change export donor csv name impress-org#2964
f987f6f
@raftaar1191 raftaar1191 mentioned this issue Apr 2, 2018
Merged
3 tasks
DevinWalker added a commit that referenced this issue Apr 5, 2018
@DevinWalker
Merge branch 'release/2.1' into issue/2900
17fd784 
* release/2.1: (23 commits)
  refactor(form): make goal more performant and add support for donor goal #2986
  refactor(admin-form): add support for donor goal
  refactor(admin-form): add support for displaying goal column
  refactor(admin-form): add support for new donor goal type and remove unused method
  fix(form): enable donor count cache logic
  fix(db-update): return success if zero new update count
  fix(db-update): update update health check logic
  add todo
  style(code): improve fn doc
  fix(form): cache donor count
  refactor(form): move helper fn to forms/functions.php
  style(code): improve code formatting
  feat(helper-function): add fn to get donor count for form
  feat(admin-forms): add new goal screen
  refactor(form-setting): add new option for "Number of Donors" and adjusted the description #2986
  fix(donor-admin-pages): remove # from id for consistency
  fix(donation-detail-page): remove # from id for consistency
  fix(admin-tools): update donation status logic #2982
  feat(admin-tool): change export donor csv name #2964
  refactor(admin-tool): change column name in CSV and checkbox #2964
  ...
@raftaar1191
Copy link
Contributor

raftaar1191 commented May 1, 2018 •
edited

Not working as expected reopening this issue and fixing it

@raftaar1191 raftaar1191 reopened this May 1, 2018
@raftaar1191 raftaar1191 mentioned this issue May 1, 2018
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raftaar1191 raftaar1191

Labels
None yet
Projects
None yet
Milestone
Sprint: 2018/03/28 - 2018/04/17
Development

No branches or pull requests
4 participants
@mehul0810 @kevinwhoffman @Benunc @raftaar1191