Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin-tool): merge CSV toolbox into Give core #2875

Closed
9 of 10 tasks
DevinWalker opened this issue Mar 6, 2018 · 5 comments
Closed
9 of 10 tasks

feat(admin-tool): merge CSV toolbox into Give core #2875

DevinWalker opened this issue Mar 6, 2018 · 5 comments
Assignees

Comments

@DevinWalker
Copy link
Member

DevinWalker commented Mar 6, 2018

Issue Overview

The CSV toolbox has proven useful enough to be merged into core: https://github.com/WordImpress/Give-CSV-Toolbox

Task List

  • Remove the old Give Donation History functionality
  • update code to support with Give 2.0 DB upgrade
  • Add export Donation Link to submenu pages that export Donation History
  • Update Give-CSV-Toolbox functionality so admin can select all form option and then export the donation ( Hide FFM, Custom Filed and Hidden Custom Field Columns when all Donation form is selected from DropDown )
  • Add export Donation Link to submenu pages that export Donation History
  • Let's also make sure that FFM, Custom Filed, and Hidden Custom Field Columns sections only display if there is actually a checkbox available within the section
  • Fix issues fix(admin-tools): sorting donation with date is failing #2978 ( Issues closed not able to reproduce the issues again )
  • Delete Give-CSV-Toolbox repository and write a blog post about it

Related Issues

@kevinwhoffman kevinwhoffman changed the title Merge CSV toolbox into Give core feat(admin-tool): merge CSV toolbox into Give core Mar 11, 2018
@kevinwhoffman kevinwhoffman added this to the Sprint: 2018/03/28 - 2018/04/10 milestone Mar 28, 2018
@raftaar1191
Copy link
Contributor

raftaar1191 commented Mar 29, 2018

Hey @DevinWalker @ravinderk @kevinwhoffman Need your help with UI

Here I am thinking of adding a new option to Export called Export Donation History on per Form Basic like we have done in Import tab where we have to click on a button and a new page opens up ( Submenu ) and then it will contain the setting to export the CSV

Video Link: https://screencast-o-matic.com/watch/cFeUXsDp3K

image

image

@kevinwhoffman
Copy link
Contributor

@raftaar1191 @DevinWalker I think you are on the right track with your recommendation, but I would like to avoid having two different options to export Donation History. I think we should be able to handle it all through the CSV toolbox UI. Please see the video below and the updated tasks on this issue.

https://drive.google.com/open?id=1o4J-Z669aKS4v6Un-dXqjdYFWbFtMHWj

@raftaar1191
Copy link
Contributor

Slack Call Summary

Participants: @DevinWalker, @raftaar1191
Topic: Plan for the UI and for 2964
Result: Had a call with @DevinWalker on the above issues and come to the conclusion that we are going to remove the old Give Donation History functionality and replace it with Give-CSV-Toolbox so we don't need to fix 2964 we are going to remove this
About UI we are going to follow the above mention UI that is being suggested @kevinwhoffman

@kevinwhoffman
Copy link
Contributor

@raftaar1191 Let's also make sure that these three sections only display if there is actually a checkbox available within the section. This will keep the initial presentation of the UI clean and simple for users who don't have Form Field Manager or Custom Fields.

image

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Mar 30, 2018
raftaar1191 added a commit to raftaar1191/Give that referenced this issue Mar 30, 2018
raftaar1191 added a commit to raftaar1191/Give that referenced this issue Apr 1, 2018
raftaar1191 added a commit to raftaar1191/Give that referenced this issue Apr 1, 2018
raftaar1191 added a commit to raftaar1191/Give that referenced this issue Apr 1, 2018
raftaar1191 added a commit to raftaar1191/Give that referenced this issue Apr 1, 2018
@Benunc
Copy link
Member

Benunc commented Apr 2, 2018

I've updated the number reported label here, and want to also add some user insight.

The main sticking point with Donor exports (and the only thing for which the workaround is "you'll have to manually merge two CSVs" is how billing address data is currently handled. If a Donor is also a WordPress user, donor data exports will export address data. If the donor is not a user, no address data is exported, because address data is currently tied only to WP user, or to Donation, not Donor.

Since the advent of the CSV toolbox, this is the most glaring pain point left in terms of donor data export.

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Apr 2, 2018
raftaar1191 added a commit to raftaar1191/Give that referenced this issue Apr 2, 2018
raftaar1191 added a commit to raftaar1191/Give that referenced this issue Apr 3, 2018
raftaar1191 added a commit to raftaar1191/Give that referenced this issue Apr 3, 2018
raftaar1191 added a commit to raftaar1191/Give that referenced this issue Apr 4, 2018
DevinWalker pushed a commit that referenced this issue Apr 6, 2018
feat(admin-tool): merge CSV toolbox into Give core #2875
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants