Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esc_html doesn't expect a textdomain #781

Closed
DevinWalker opened this issue Jul 21, 2016 · 2 comments
Closed

esc_html doesn't expect a textdomain #781

DevinWalker opened this issue Jul 21, 2016 · 2 comments
Assignees
@ramiy
Milestone
1.6

Comments

@DevinWalker
Copy link
Member

The WP core function esc_html only expects one parameter yet we are passing two with the text domain here: https://github.com/WordImpress/Give/blob/release/1.6/includes/scripts.php#L254%23L271

I believe https://codex.wordpress.org/Function_Reference/esc_html_2 should be used in place.

Please check uses of esc_html due to merge of #776
@DevinWalker DevinWalker added this to the 1.6 milestone Jul 21, 2016
@ramiy
Copy link
Contributor

ramiy commented Jul 21, 2016

Good catch!

@ramiy ramiy mentioned this issue Jul 21, 2016
Closed
@DevinWalker
Copy link
Member Author

Resolved with PR merge #811

DevinWalker pushed a commit that referenced this issue Jul 26, 2016
Merge branch 'release/1.6' into issue/668
90448a0 
* release/1.6: (284 commits)
  Change log entry for #471
  Resolved merge issue after 1.6 > this branch
  Fixed strings not escaped properly after merge of 1.6 into this branch
  Added change log item for #411 fix
  Change log item added for #757
  Sentence closure & spacing
  Do not pass more then 3 params to remove_filter
  Refactor give_show_goal_progress function
  i18n sucurity: escaping translation strings #471
  Add template for give goals shortcode
  Add give_get_template function
  Remove testing code
  Remove code from get_data function
  Add form id abd form title csv column to export donation history csv
  Period for proper doc block
  i18n: replace esc_attr() with esc_attr__() #781
  Corrects capitalization for proper localization
  i18n: replace esc_html() with esc_html__() #781
  Gulp after merge
  Fix issue with non-RTL Donation Information table th not being aligned to left
  ...

Resolved Conflicts:
	includes/admin/class-give-settings.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ramiy ramiy

Labels
None yet
Projects
None yet
Milestone
1.6
Development

No branches or pull requests
2 participants
@ramiy @DevinWalker