Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export Donation History no longer has Form Title and also has unnecessary columns #757

Closed
mathetos opened this issue Jul 19, 2016 · 1 comment
Closed

Export Donation History no longer has Form Title and also has unnecessary columns #757

mathetos opened this issue Jul 19, 2016 · 1 comment
Assignees
@ravinderk
Milestone
1.6

Comments

@mathetos
Copy link
Member

Somehow this commit: #414 reverted the improvements to the Export made in this commit: #314

Just tested from version 1.3.1 until 1.4.5 the Form Title appeared correctly with the "Export Donation History - Download a CSV of all donations recorded" report. But with 1.5 and the new Date Range feature, the Form Title.

VERSION 1.4.5
export-history-1-4-5-correct

VERSION 1.5+
export-history-1-5-3-wrong
@mathetos mathetos added the bug label Jul 19, 2016
@Benunc
Copy link
Member

Benunc commented Jul 19, 2016 •
edited

I was about to report that I had a "products" column that seemed out of place.

@DevinWalker DevinWalker self-assigned this Jul 19, 2016
@DevinWalker DevinWalker added this to the 1.6 milestone Jul 19, 2016
@DevinWalker DevinWalker assigned ravinderk and unassigned DevinWalker Jul 26, 2016
@ravinderk ravinderk mentioned this issue Jul 26, 2016
Merged
DevinWalker pushed a commit that referenced this issue Jul 26, 2016
Change log item added for #757
191a4de
DevinWalker pushed a commit that referenced this issue Jul 26, 2016
Merge branch 'release/1.6' into ramiy-release/1.6
6203015 
* release/1.6:
  Added change log item for #411 fix
  Change log item added for #757
  Sentence closure & spacing
  Do not pass more then 3 params to remove_filter
  Refactor give_show_goal_progress function
  Add template for give goals shortcode
  Add give_get_template function
  Remove testing code
  Remove code from get_data function
  Add form id abd form title csv column to export donation history csv

# Conflicts:
#	includes/admin/reporting/export/class-batch-export-payments.php
#	includes/forms/template.php
DevinWalker pushed a commit that referenced this issue Jul 26, 2016
Merge branch 'release/1.6' into issue/668
90448a0 
* release/1.6: (284 commits)
  Change log entry for #471
  Resolved merge issue after 1.6 > this branch
  Fixed strings not escaped properly after merge of 1.6 into this branch
  Added change log item for #411 fix
  Change log item added for #757
  Sentence closure & spacing
  Do not pass more then 3 params to remove_filter
  Refactor give_show_goal_progress function
  i18n sucurity: escaping translation strings #471
  Add template for give goals shortcode
  Add give_get_template function
  Remove testing code
  Remove code from get_data function
  Add form id abd form title csv column to export donation history csv
  Period for proper doc block
  i18n: replace esc_attr() with esc_attr__() #781
  Corrects capitalization for proper localization
  i18n: replace esc_html() with esc_html__() #781
  Gulp after merge
  Fix issue with non-RTL Donation Information table th not being aligned to left
  ...

Resolved Conflicts:
	includes/admin/class-give-settings.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ravinderk ravinderk

Labels
None yet
Projects
None yet
Milestone
1.6
Development

No branches or pull requests
4 participants
@mathetos @DevinWalker @ravinderk @Benunc