Issue/826 #1214
Merged
Issue/826 #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o issue/826 # Conflicts: # assets/css/give-admin-rtl.min.css # assets/css/give-admin.min.css # assets/sourcemaps/give-admin.css.map
DevinWalker
approved these changes
Nov 9, 2016
|
@kevinwhoffman this is looking and working great. I just have one request. When a license is active can that show win green or perhaps a green checkmark? And then when unlicensed can we show it in red or an "x" icon? You choose.
|
ravinderk
reviewed
Dec 28, 2016
| $posting['wp_remote_get']['success'] = false; | ||
| } | ||
|
|
||
| $posting = apply_filters( 'woocommerce_debug_posting', $posting ); |
There was a problem hiding this comment.
@kevinwhoffman Can we rename this to give_debug_posting
There was a problem hiding this comment.
@ravinderk Yes, thanks.
ravinderk
reviewed
Dec 28, 2016
| $posting['wp_remote_get']['name'] = __( 'Remote Get', 'give'); | ||
| $posting['wp_remote_get']['help'] = __( 'Give plugins may use this method of communication when checking for plugin updates.', 'give' ); | ||
|
|
||
| $response = wp_safe_remote_get( 'https://woocommerce.com/wc-api/product-key-api?request=ping&network=' . ( is_multisite() ? '1' : '0' ) ); |
There was a problem hiding this comment.
@kevinwhoffman Can we use givewp.com or same site to check get request?
There was a problem hiding this comment.
There was a problem hiding this comment.
@ravinderk Yes, that should be changed to use givewp.com since the purpose of the test is to confirm that the current site can check for plugin updates.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR overhauls the System Info screen with the following changes:
How Has This Been Tested?
Screenshots (jpeg or gifs if applicable):
Plain Text Report (Expanded)
Full System Info Screen
Types of changes
Addresses the system info requests in #826. Note that TLS 1.2 detection will be addressed in #810.
Checklist: