Fix show/hide tab process lagging #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is looking good, much smoother. A few more things: Expanding to Larger Screensize
Clicking Outside Expanded Dropdown Doesn't Close ItWhen you click to expand the dropdown, then click outside it the dropdown should close. Not Removing at WordPress Admin's Mobile Breakpoint
At a certain point the wp-admin kicks in and redesigns the tabs to buttons that stack. We should improve this so that it turns into a mobile menu like so:
-- full width |
DevinWalker
requested changes
Feb 3, 2017
|
@DevinWalker All issues fixed. Please review them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will fix setting tab show/hide process lagging between window resize.
Fix #1413
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: