Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue/1423 - With Code Updates from Devin Walker #1792

Merged
merged 3 commits into from
Jun 26, 2017

Conversation

DevinWalker
Copy link
Member

Description

Code updates by myself from #1780

@DevinWalker DevinWalker mentioned this pull request Jun 26, 2017
3 tasks
@DevinWalker DevinWalker changed the title Updated from "goals" to "goal" singular issue/1423 - With Code Updates from Devin Walker Jun 26, 2017
@DevinWalker
Copy link
Member Author

@mehul0810 please take note of this newly added unit test: https://github.com/WordImpress/Give/pull/1792/files#diff-0dd4e997d722238d85aeb744bcede922R322

Please take care to write unit tests whenever possible to verify the code.

@DevinWalker DevinWalker merged commit da99265 into release/1.8.9 Jun 26, 2017
@DevinWalker DevinWalker deleted the mehul0810-issue/1423 branch August 3, 2017 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant