Issue/1423 #1780
Closed
Issue/1423 #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravinderk
requested changes
Jun 14, 2017
includes/api/class-give-api.php
Outdated
| @@ -1037,6 +1037,13 @@ private function get_form_data( $form_info ) { | |||
| $form['info']['tags'] = get_the_terms( $form_info, 'give_forms_tag' ); | |||
| } | |||
|
|
|||
| if ( give_is_setting_enabled( give_get_meta( $form_info->ID, '_give_goal_option', true ) ) ) { | |||
| $goal_amount = give_get_meta( $form_info->ID, '_give_set_goal', true ); | |||
| $goal_percentage_completed = round( ( give_get_form_earnings_stats( $form_info->ID ) / $goal_amount ) * 100 ); | |||
There was a problem hiding this comment.
@mehul0810 This code will generate PHP notice.
PHP Warning: Division by zero in /wp-content/plugins/Give/includes/api/class-give-api.php on line 1042
And also max percentage should be 100
for ref: https://github.com/WordImpress/Give/blob/master/templates/shortcode-goal.php#L50
There was a problem hiding this comment.
@ravinderk I've updated the code, considering both the above mentioned scenarios
ravinderk
requested changes
Jun 14, 2017
includes/api/class-give-api.php
Outdated
| // Check whether any goal is to be achieved for the donation form | ||
| $goal_option = give_get_meta( $form_info->ID, '_give_goal_option', true ); | ||
| $goal_amount = give_get_meta( $form_info->ID, '_give_set_goal', true ); | ||
| if ( give_is_setting_enabled( $goal_option ) && isset( $goal_amount ) && $goal_amount > 0 ) { |
There was a problem hiding this comment.
@mehul0810 change this to if ( give_is_setting_enabled( $goal_option ) && $goal_amount )
There was a problem hiding this comment.
@ravinderk I've implemented this change and liked it so much 👍
ravinderk
approved these changes
Jun 14, 2017
|
Closing in favor of #1792 with my code updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for #1423
How Has This Been Tested?
Tested this with 2 possible scenarios:
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: