Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/2189 #2273

Merged
merged 4 commits into from
Nov 2, 2017
Merged

Issue/2189 #2273

merged 4 commits into from
Nov 2, 2017

Conversation

mehul0810
Copy link
Contributor

Description

This PR is for #2189

How Has This Been Tested?

I've tested this issue fix in desktop, tablet and mobile screens to keep the same color combinations for all the screen at once. Also, re-positioned the sub-nav in desktop screens so that it provide the feel of opening for the additional tab icon.

Screenshots (jpeg or gifs if applicable):

Before

Desktop:
image

Mobile:
image

After

Desktop:
image

Mobile:
image

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@DevinWalker
Copy link
Member

Looks really nice @mehul0810 👍

@DevinWalker DevinWalker merged commit 0a4c103 into impress-org:release/1.8.17 Nov 2, 2017
@mehul0810 mehul0810 deleted the issue/2189 branch December 8, 2017 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants