Issue/2493 #2494
Merged
Issue/2493 #2494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravinderk
requested changes
Dec 11, 2017
includes/class-give-email-access.php
Outdated
|
|
||
| // Columns added properly | ||
| if ( $query ) { | ||
| give_update_option( 'email_access_installed', 1 ); |
There was a problem hiding this comment.
@mehul0810 Write automatic upgrade to remove email_access_installed.
There was a problem hiding this comment.
@ravinderk Added Automatic Upgrade as well as improved the functioning of creating columns as discussed over call.
ravinderk
approved these changes
Dec 12, 2017
DevinWalker
reviewed
Dec 20, 2017
| * | ||
| * @return bool | ||
| */ | ||
| public function is_column_exists( $column_name ) { |
There was a problem hiding this comment.
@mehul0810 I'd love to get this renamed to does_column_exist( $column_name ) pre-1.8.18 release
DevinWalker
added a commit
that referenced
this pull request
Dec 20, 2017
…_column_exist` - revises PR #2494
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolved #2493
How Has This Been Tested?
I've tested this by setting
email_access_installedtofalseand then confirming whether the notice still appears in error log or not.Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: