Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new entity restrictions API #13

Closed
JDGrimes opened this issue Nov 23, 2016 · 1 comment
Closed

Use new entity restrictions API #13

JDGrimes opened this issue Nov 23, 2016 · 1 comment
Assignees
@JDGrimes
Labels
bug
Milestone
1.0.0

Comments

@JDGrimes
Copy link
Member

Instead of the old interface. See WordPoints/wordpoints#541.
@JDGrimes JDGrimes added the bug label Nov 23, 2016
@JDGrimes JDGrimes added this to the 1.0.0 milestone Nov 23, 2016
@JDGrimes JDGrimes self-assigned this Nov 23, 2016
@JDGrimes
Copy link
Member Author

We are using this only for the message entity. The interesting thing here is that messages are really always private, they are never public. Which means that is_accessible() will always return false. Which is fine, it just threw me off for a second, since this is the first such entity we've come across.

JDGrimes added a commit to WordPoints/dev-lib that referenced this issue Dec 20, 2016
@JDGrimes
phpunit: set target in even testcase
4819421 
Set the target as a property of the testcase so that it is accessible to the `fire_event()` method.

This proved useful when working on WordPoints/buddypress#13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JDGrimes JDGrimes

Labels
bug
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@JDGrimes