-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add acceptance tests #92
Comments
JDGrimes
added a commit
that referenced
this issue
Feb 7, 2016
I haven’t added the composer config for installing wp-browser and codeception, because I haven’t figured out how to run the tests on Travis CI yet, and unless we are running the tests, it is just wasting time and resources to have composer install the dependencies (and there are lots of them). See #92
JDGrimes
added a commit
that referenced
this issue
Feb 7, 2016
JDGrimes
added a commit
that referenced
this issue
Feb 7, 2016
JDGrimes
added a commit
that referenced
this issue
Feb 8, 2016
JDGrimes
added a commit
that referenced
this issue
Feb 8, 2016
Accidentally inverted this check. See #92
JDGrimes
added a commit
that referenced
this issue
Feb 8, 2016
JDGrimes
added a commit
that referenced
this issue
Feb 11, 2016
Otherwise Codeception will think that it isn’t running even though it is. And don’t divert its output, so that we can debug it. See #92
JDGrimes
added a commit
that referenced
this issue
Feb 11, 2016
JDGrimes
added a commit
that referenced
this issue
Feb 15, 2016
Because on Travis CI the password is empty, and using the short option will force the password prompt in that case. See #92, WordPoints/dev-lib#46
JDGrimes
added a commit
that referenced
this issue
Feb 20, 2016
JDGrimes
added a commit
that referenced
this issue
Feb 20, 2016
JDGrimes
added a commit
that referenced
this issue
Feb 20, 2016
This was failing because the quotes were being added by `escapeshellarg()`, so we didn’t need to add a second set. Also, because the value was quoted, the empty value would actually be equal to `”’’”`, and not `’’`. Anyway, we leave out the password entirely for `mysqldump`, but leave it in even if empty for `mysql`, so we can test to see if both ways work. if they do, we’ll just pass the empty passwords to the commands, since the logic is simpler. See #92, #46
JDGrimes
added a commit
that referenced
this issue
Feb 29, 2016
JDGrimes
added a commit
that referenced
this issue
Feb 29, 2016
JDGrimes
added a commit
that referenced
this issue
May 2, 2016
JDGrimes
added a commit
that referenced
this issue
May 5, 2016
The latest version is no longer working with the version of Codeception that we are using (2.1.4). Probably we should update them both, but I want to get this working again before I mess with that. The error that currently occurs in Travis: ``` PHP Fatal error: Class 'Codeception\Application' not found in /home/travis/build/WordPoints/hooks-api/vendor/lucatume/wp-browser/wpcep t on line 13 PHP Stack trace: PHP 1. {main}() /home/travis/build/WordPoints/hooks-api/vendor/lucatume/wp-browser/wpcep t:0 ``` See #92
JDGrimes
added a commit
that referenced
this issue
May 14, 2016
The syntax we were using before wasn’t recognized. I guess maybe you can’t specify a commit hash along with `master@dev`. See #92
JDGrimes
added a commit
that referenced
this issue
May 17, 2016
The `cat` command below it is complaining that the file doesn’t exist. See #92
JDGrimes
added a commit
that referenced
this issue
May 23, 2016
JDGrimes
added a commit
that referenced
this issue
May 24, 2016
JDGrimes
added a commit
that referenced
this issue
May 28, 2016
JDGrimes
added a commit
that referenced
this issue
May 28, 2016
It is expected, and if not present can give a notice. See #92
JDGrimes
added a commit
that referenced
this issue
May 28, 2016
We called it “save”, but “create” is more descriptive. See #92
JDGrimes
added a commit
that referenced
this issue
May 28, 2016
JDGrimes
added a commit
that referenced
this issue
May 28, 2016
The button should be disabled when we add a new reaction, and then re-enabled after that reaction is saved. See #92
JDGrimes
added a commit
that referenced
this issue
May 28, 2016
This is better if somebody wants to extend this class in the future. See #92
JDGrimes
added a commit
that referenced
this issue
May 28, 2016
Keeps the streamlining methods together. See #92
JDGrimes
added a commit
that referenced
this issue
May 28, 2016
This saves time in the tests by cutting out a step. See #92
JDGrimes
added a commit
that referenced
this issue
May 28, 2016
Rather than asserting that we don’t have a disabled button. The whole button being gone would fulfill that requirement. See #92
JDGrimes
added a commit
that referenced
this issue
May 28, 2016
JDGrimes
added a commit
that referenced
this issue
May 28, 2016
JDGrimes
added a commit
that referenced
this issue
May 28, 2016
JDGrimes
added a commit
that referenced
this issue
May 28, 2016
JDGrimes
added a commit
that referenced
this issue
May 28, 2016
JDGrimes
added a commit
that referenced
this issue
May 28, 2016
We’ve been moving things around. See #92
JDGrimes
added a commit
that referenced
this issue
May 31, 2016
We run the PHP server in this dir, but I’m now wondering whether it is correct, because WordPress isn’t being loaded. See #92
JDGrimes
added a commit
that referenced
this issue
Jun 13, 2016
JDGrimes
added a commit
that referenced
this issue
Jun 13, 2016
We're still figuring running these on Travis CI out, but we've been tracking that in WordPoints/dev-lib#46 anyway. So we can close this out now. |
JDGrimes
added a commit
that referenced
this issue
Jun 13, 2016
JDGrimes
added a commit
that referenced
this issue
Jun 13, 2016
When running the acceptance tests this is necessary. See #92, WordPoints/dev-lib#46
JDGrimes
added a commit
that referenced
this issue
Jun 14, 2016
JDGrimes
added a commit
that referenced
this issue
Jun 14, 2016
Wait until just before we are running the codeception tests. See #92, WordPoints/dev-lib#46
JDGrimes
added a commit
that referenced
this issue
Jun 14, 2016
JDGrimes
added a commit
that referenced
this issue
Jun 14, 2016
We had limited this to a single test for debugging. See #92, WordPoints/dev-lib#46
JDGrimes
added a commit
that referenced
this issue
Jun 14, 2016
We don’t need to use this to run our acceptance tests when we are using the PhantomJS browser, so starting it is just a waste of time. See #92, WordPoints/dev-lib#46
JDGrimes
added a commit
that referenced
this issue
Jun 14, 2016
We wanted all the info we could get for debugging, but now that things are working, there’s no need. See #92, WordPoints/dev-lib#46
JDGrimes
added a commit
that referenced
this issue
Jun 14, 2016
We aren’t debugging anymore! See #92, WordPoints/dev-lib#46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We probably can't cover the whole UI at this point, but I'd like to get something started at least. See #91.
The text was updated successfully, but these errors were encountered: