Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new dev-lib #262

Closed
JDGrimes opened this issue Jan 26, 2015 · 2 comments
Closed

Use new dev-lib #262

JDGrimes opened this issue Jan 26, 2015 · 2 comments
Milestone

Comments

@JDGrimes
Copy link
Member

See WordPoints/dev-lib#2

We may want to integrate this with the dev-lib from xwp that we currently use, or just use them both separately.

@JDGrimes JDGrimes modified the milestone: 1.10.0 Feb 2, 2015
JDGrimes added a commit that referenced this issue Feb 7, 2015
@JDGrimes
Copy link
Member Author

The only issue is that there is a failure on WordPress nightly:

https://travis-ci.org/WordPoints/wordpoints/jobs/50124821#L1663

There was 1 failure:

1) WordPoints_Points_1_5_1_Update_Test::test_db_table_charsets_updated

Failed asserting that 'CREATE TABLE `wptests_wordpoints_points_logs` (

`id` bigint(20) NOT NULL AUTO_INCREMENT,

`user_id` bigint(20) NOT NULL,

`log_type` varchar(255) COLLATE utf8mb4_unicode_ci NOT NULL,

`points` bigint(20) NOT NULL,

`points_type` varchar(255) COLLATE utf8mb4_unicode_ci NOT NULL,

`text` longtext COLLATE utf8mb4_unicode_ci,

`blog_id` smallint(5) unsigned NOT NULL,

`site_id` smallint(5) unsigned NOT NULL,

`date` datetime NOT NULL DEFAULT '0000-00-00 00:00:00',

PRIMARY KEY (`id`),

KEY `user_id` (`user_id`),

KEY `points_type` (`points_type`(191)),

KEY `log_type` (`log_type`(191))

) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci' ends with "DEFAULT CHARSET=utf8".

/home/travis/build/WordPoints/wordpoints/tests/phpunit/tests/points/update/1-5-1.php:74

FAILURES!

Tests: 344, Assertions: 770, Failures: 1, Incomplete: 1, Skipped: 25.

The command "phpunit-basic" exited with 1.

@JDGrimes JDGrimes modified the milestones: 1.9.3, 1.10.0 Feb 10, 2015
@JDGrimes
Copy link
Member Author

Fixed.

@JDGrimes JDGrimes modified the milestones: 1.9.3, 1.10.0 Feb 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant