Compatibility-fix for PHPCS 3.4.0 #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A fix for upstream issue 1574 - tokenize binary casts as `T_BINARY_CAST` - has been committed to PHPCS and will be included in the PHPCS 3.4.0 release.
* The upstream change fixes a false negative in the `PHP.TypeCasts` sniff.
* There are two more sniffs which look at cast tokens `PHP.YodaConditions` and `WP.EnqueuedResourceParameters`.
- For the first, I've just added a unit test documenting the behaviour.
- For the second, I realized that the use of cast tokens wasn't tested at all. So I've added tests to that effect, including tests using binary casts.
GaryJones
approved these changes
Nov 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for upstream issue squizlabs/PHP_CodeSniffer#1574 - tokenize binary casts as
T_BINARY_CAST- has been committed to PHPCS and will be included in the PHPCS 3.4.0 release.PHP.TypeCastssniff.PHP.YodaConditionsandWP.EnqueuedResourceParameters.