Fix duplicate error being thrown / space after cast #1518
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the following test code:
The current sniffs/ruleset would result in the following errors related to cast spacing:
The errors for line 3 are basically duplicates.
Additionally, as shown by line 4, as the upstream sniff also checks the width of the space after a type cast, that sniff is the better choice.
So in this PR, I'm removing the code which generated the
WordPress.WhiteSpace.CastStructureSpacing.NoSpaceAfterCloseParenthesis
error.Includes adjusted unit test
fixed
file.