Add process() method to WordPress_Sniff …
#833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n()` method in child classes. This saves us having to call `$this->init()` from every child class, always sets the basic properties and makes them available to the child classes.
jrfnl
force-pushed
the
feature/simplify-use-WP-sniff-class
branch
from
37593b7
to
d5dabfc
Compare
|
Rebased for merge conflict |
JDGrimes
approved these changes
Feb 10, 2017
There was a problem hiding this comment.
Let's do it.
Note that I compared the performance of this with current develop, and there is almost no difference at all.
Because I'm obsessed with performance of a tool that is just used to sniff my actual code. Yeah.
|
@JDGrimes Thanks & thanks for keeping an eye on performance. As for the most part the functionality used hasn't changed, just the way it is called, your findings are in line with what I expected. |
|
Let me tidy up the follow up branch & I'll try & pull it later today (as in Florida today) |
|
😎 |
|
Ok, pulled - see #841 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and change to
process_token()method in child classes.This saves us having to call
$this->init()from every child class, always sets the basic properties and makes them available to the child classes.This PR addresses the third bullet from issue #765
P.S.: For the CronInterval sniff, the changes have been kept to a minimum to avoid large conflicts with #818.As #818 has been merged, fixed up the CronInterval sniff to be inline with the rest of the PR.