FileNameUnitTest: Re-enable the unit tests for non-strict class names. #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
feature/re-enable-strict-class-file-name-unit-tests
branch
from
7d7e0ed
to
d0c528a
Compare
The unit tests for non-strict class names were never enabled as the directory in which the test files live, wasn't listed in the `glob()` call. This was previously not corrected as the `@codingStandardsChangeSetting` directives did not seem to work well in combination with a PHP open tag as the target token. This has now been fixed. The unit tests should now pass and the directory has been included by making the `glob()` call more dynamic which will automatically include additional directories if these would be added in the future.
JDGrimes
approved these changes
Apr 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit tests for non-strict class names were never enabled as the directory in which the test files live, wasn't listed in the
glob()call.This was previously not corrected as the
@codingStandardsChangeSettingdirectives did not seem to work well in combination with a PHP open tag as the target token.This has now been fixed. The unit tests should now pass and the directory has been included by making the
glob()call more dynamic which will automatically include additional directories if these would be added in the future.