Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ControlStructureSpacing sniff: fix blank line after control structure / disappearing comment #981

Merged
merged 3 commits into from Jun 20, 2017
Merged

ControlStructureSpacing sniff: fix blank line after control structure / disappearing comment #981

merged 3 commits into from Jun 20, 2017

Commits on Jun 18, 2017

  1. ControlStructureSpacing sniff: add unit test for disappearing comment

    @jrfnl
    jrfnl committed Jun 18, 2017
    Copy the full SHA
    e971d32 View commit details
    Browse the repository at this point in the history

  2. Revert "ControlStructureSpacing: No need to check separately for comm… 

    …ents."

This effectively reverts commit 786c9bb.
    @jrfnl
    jrfnl committed Jun 18, 2017
    Copy the full SHA
    b747adc View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2017

  1. ControlStructureSpacing sniff: Sync in more changes from upstream for… 

    … the "blank line after" check

The upstream sniff is *not* properly unit tested with a fixed file and in part checks for something different and therefore uses different logic.

This commit adds unit tests for our version of the sniff, syncs in a number of good changes from upstream and fixes a number of bugs related to this particular check & fixer.
    @jrfnl
    jrfnl committed Jun 19, 2017
    Copy the full SHA
    2536aac View commit details
    Browse the repository at this point in the history