Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tutorial Presenter Application form check box sign not proper alignment. #2221

Open
vipulupadala-multidots opened this issue Feb 15, 2024 · 3 comments
Open

Tutorial Presenter Application form check box sign not proper alignment. #2221

vipulupadala-multidots opened this issue Feb 15, 2024 · 3 comments
Labels
[Dev] Has PR Website related issue that also has a related pull request.

Comments

@vipulupadala-multidots
Copy link

Type of feedback

Need to improve the check box sign design for The Tutorial Presenter Application form page.

Description

I have reviewed the meta site and during the Tutorial Presenter Application form check box design is not properly displayed. So think we need to improve some design.

Step-by-step reproduction instructions (optional)

  1. First Open the URL
  2. Select the check box and see design not displayed properly

Screenshots or screen recording (optional)

Screenshot: https://share.cleanshot.com/fK9BS8FH07DgbNPsMwKD
@vipulupadala-multidots vipulupadala-multidots added the Awaiting Triage Issues awaiting triage. See Training Team handbook for how to triage issues. label Feb 15, 2024
@devmuhib009
Copy link
Contributor

Thanks @vipulupadala-multidots for creating the issue.

@devmuhib009 devmuhib009 added [Content] Feedback Feedback provided about content on Learn. and removed Awaiting Triage Issues awaiting triage. See Training Team handbook for how to triage issues. labels Feb 15, 2024
vipulupadala-multidots added a commit to vipulupadala-multidots/Learn that referenced this issue Feb 15, 2024
@vipulupadala-multidots
WordPress#2221 number issues is resolved
2a89dcb
@digitalchild digitalchild added [Dev] Has PR Website related issue that also has a related pull request. and removed [Content] Feedback Feedback provided about content on Learn. labels Feb 16, 2024
unprintedch added a commit to unprintedch/Learn that referenced this issue Apr 1, 2024
@unprintedch
try to algin jetpack form checkbox with sensei.
ec54a10 
WordPress#2221 - try to align jetpack form checkbox with sensei.

Added a hook for custom class in jetpack form fields (wporg-learn-form)
Style it
@unprintedch unprintedch mentioned this issue Apr 1, 2024
Open
@unprintedch
Copy link

I did try something.

There is couple of question in the PR. I put them back here for easy discussion.

Open questions:
How could we make a good use of sensei css variables?
I use the SVG icon in the CSS, I find it bad... (and the linter too) can someone tell me how to do it properly?
And where to put this "checkbox.scss" it is an override of a vendor, any good practice?

@unprintedch
Copy link

I just notice that there was already a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Dev] Has PR Website related issue that also has a related pull request.
Projects
LearnWP Website Development
Status: To do
Milestone
No milestone
Development

No branches or pull requests
4 participants
@digitalchild @unprintedch @vipulupadala-multidots @devmuhib009