Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use repo-tools configs for linting #2399

Closed
adamwoodnz opened this issue Apr 24, 2024 · 0 comments · Fixed by #2398
Closed

Use repo-tools configs for linting #2399

adamwoodnz opened this issue Apr 24, 2024 · 0 comments · Fixed by #2398
Assignees
@adamwoodnz
Labels
[Component] Environment Website development issues related to Learn's local environment, or needs Meta team involvement.
Milestone
Learning Pathways...

Comments

@adamwoodnz
Copy link
Contributor

adamwoodnz commented Apr 24, 2024 •
edited

We already depend on wporg/wporg-repo-tools and use it for builds. For consistency of code style with our others repos we should use the lint configs too, in particular prettier and eslint. As we add more blocks in the new block theme this will become more important.

The currently installed stylelint config is already consistent with the repo-tools version and there is a custom phpcs config which should not be changed.
@adamwoodnz adamwoodnz self-assigned this Apr 24, 2024
@adamwoodnz adamwoodnz added this to the Learning Pathways launch milestone Apr 24, 2024
@adamwoodnz adamwoodnz added the [Component] Environment Website development issues related to Learn's local environment, or needs Meta team involvement. label Apr 24, 2024
@adamwoodnz adamwoodnz mentioned this issue Apr 24, 2024
Merged
bazza pushed a commit to WordPress/wordpress.org that referenced this issue Apr 30, 2024
Locale Switcher: Remove package-lock.json
75fe627 
This definition is handled by https://github.com/WordPress/Learn/blob/trunk/yarn.lock

See WordPress/Learn#2399


git-svn-id: https://meta.svn.wordpress.org/sites/trunk@13632 74240141-8908-4e6f-9713-ba540dce6ec7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamwoodnz adamwoodnz

Labels
[Component] Environment Website development issues related to Learn's local environment, or needs Meta team involvement.
Projects
WordPress.org Redesign
Status: ✅ Done
Milestone
Learning Pathways launch
Development

Successfully merging a pull request may close this issue.

Update linting to use repo-tools configs WordPress/Learn
1 participant
@adamwoodnz