-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lesson List on Course Single Page and Course Completed Page #2531
Comments
@WordPress/learn-team Is it possible for a lesson to not belong to a module? I haven't seen this for recently created lessons, but I've noticed it's the case for some older lessons. This could affect how a lesson is rendered. Update Lessons belong to a module: https://learn.wordpress.org/course/beginner-wordpress-user/ |
@renintw agreed. We have not created stand-alone lessons recently, but we would like to have the ability to have stand alone lessons that would be rendered on their own. |
I took a look at this and here is an idea I made based on the screenshots attached in the first comment. Users not enrolledInteractionHere is how the interaction could work Notes
What do you think of this @renintw? Here is the section in Figma where all mockups are. If this works, I plan to update the mockups in Design |
I've looked into it a bit and it turns out the "Preview" pill comes from this setting of a lesson post. If it's not checked, there won't be a "Preview" pill:
ref: https://learn.wordpress.org/course/developing-your-first-wordpress-block/ Note
|
@fcoveram Thanks for the design update! They look great, except for a few questions being brought up above.
I'd also like to know @adamwoodnz thoughts on the updated progress bar and other updated design. |
LGTM! |
Done. I moved it to the bottom
To keep consistency, I included the On the other hand, I cleaned up the sections in the Design page to distinguish between mockups for Courses and Lessons. In each, I included the sidebar and lesson list variants for courses as assets. I hope this works. Let me know if I'm missing something. Regarding your notes
I would go with something very simple. Put the sign-in button next to the blue one with the same style as the “Practice on a private demo site” button on the course page.
I couldn’t find a Lesson showing this. Can you share a link to understand the context? |
sorry that I missed attaching an example for that one: https://learn.wordpress.org/course/beginner-wordpress-developer/ |
Awesome. Now I understand.
Not really. The eye is redundant as the link itself conveys the preview action. |
Update the Lesson List style on the Course single page and the Completed page. Some details moved from here:
Yes, there are three cases. Not started, In Progress, and Completed.
I think we can make changes, but I will open another ticket to handle it, as other than the statuses "Not Started," "In Progress," and "Completed," it looks like there are two different ways to present lessons: lessons that belong to a module and those that do not. Lessons that belong to a module have a blue border and a blue header. Those without a module only display the lesson name.
Lessons without a module seem to be very few in production, but there are still some, although they were created quite a while ago. Whether to consider these needs to be discussed with the training team (
I plan to ask about this in the new ticketUpdate: see #2531 (comment)).Additionally, the "course completed" page also displays this lesson list, which I reckon needs to be changed as well.
Update
Preview Button (When a user isn't enrolled)
The text was updated successfully, but these errors were encountered: