Course outline block header enhance #2776
Open
+25
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renintw
added
[Component] Learn Theme
adamwoodnz
reviewed
Jul 25, 2024
wp-content/themes/pub/wporg-learn-2024/src/course-outline/index.js
Outdated
Show resolved
Hide resolved
adamwoodnz
reviewed
Jul 25, 2024
|
Can we also fix #2778 in this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2614
Originally, the header was directly given a class to allow toggling, but this causes an accessibility issue since the header does not support the
aria-expanded="true"attribute and also leads to the problem of "interactive controls being nested". So here triggers the button inside the header without allowing it to bubble up.Screenshot