Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verify => false does not work with fsockopen #310

Closed
soulseekah opened this issue Feb 11, 2018 · 0 comments
Closed

verify => false does not work with fsockopen #310

soulseekah opened this issue Feb 11, 2018 · 0 comments

Comments

@soulseekah
Copy link
Contributor

The Requests_Transport_fsockopen still throws an exception regardless of the verify option on invalid SSL. Test case incoming.
@soulseekah soulseekah mentioned this issue Feb 11, 2018
Open
soulseekah added a commit to soulseekah/Requests that referenced this issue Feb 11, 2018
@soulseekah
Add verify => false tests
20510e7 
See WordPress#310 fsockopen will fail
@soulseekah soulseekah mentioned this issue Feb 11, 2018
Merged
soulseekah added a commit to soulseekah/Requests that referenced this issue Feb 11, 2018
@soulseekah
fsockopen SSL no verify == no verifyname
2c01f62 
As per the documentation setting verify to false suppresses all SSL
checks. Fixes WordPress#310
soulseekah added a commit to soulseekah/Requests that referenced this issue Feb 11, 2018
@soulseekah
Fix multi-call SSL verify propagation in cURL
659368c 
The `request_multi` method does not take into account the verify option,
unlike `request`. Moved the verify logic into `setup_handler` which does
all the `curl_setopt` calls anyway and is called from both the multiple
and single request options.

With tests. Contigent on WordPress#310 for fsockopen verify fix.

Fixes WordPress#294
@soulseekah soulseekah mentioned this issue Feb 11, 2018
Open
soulseekah added a commit to soulseekah/Requests that referenced this issue Sep 26, 2019
@soulseekah
Add verify => false tests
72c34d6 
See WordPress#310 fsockopen will fail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@soulseekah