Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit: multi-byte character awareness & handling #759

Closed
schlessera opened this issue Jul 4, 2022 · 0 comments
Closed

Audit: multi-byte character awareness & handling #759

schlessera opened this issue Jul 4, 2022 · 0 comments

Comments

@schlessera
Copy link
Member

Some parts of the Requests library are very heavy on string manipulations. There are parts of the code that calculate string lengths, use substrings, etc...

We need to do a full audit of the string-handling in Requests to ensure it handles multi-byte characters gracefully and appropriately. In some instances, this means properly discarding multi-byte characters upfront, because whatever RFC/standard/protocol disallowing their use.

In some instances, we need to have them properly pass through the string handling without causing invalid characters and random mismatches because of bad truncation of MB characters.

And for subsystems like the domain matching, we need to ensure that internationalization works properly across the combination of IDNA encoding and string manipulations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant