Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #283 : Fixes CPU busy loop(s) seen in request_multiple. #284

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fixes #283 : Fixes CPU busy loop(s) seen in request_multiple. #284

wants to merge 4 commits into from

Commits on Oct 23, 2019

  1. Fixes WordPress#283 : Fixes CPU busy loop when using request_multiple. 

    See WordPress#284 for background information

This will require more testing across various libcurl versions.
I doubt that the timeout is necessary for curl_multi_select
(calls select() if it can),
but leaving in one just in case of bugs, so that it will end.
- Haven't thoroughly checked for relevant libcurl bugs.

Asynchronously wait for events with a short timeout if CURLM_CALL_MULTI_PERFORM
fails. Use shorter timeouts when the total time elapsed so far is
shorter. Make the largest possible manual usleep 2ms.
    @TysonAndre
    TysonAndre committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    437cecf View commit details
    Browse the repository at this point in the history

  2. Comment nit

    @TysonAndre
    TysonAndre committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    fade412 View commit details
    Browse the repository at this point in the history

  3. Sleep for less time. 

    It seems like long-lived request_multiple operations are more affected
by the sleep statements that were added.
    @TysonAndre
    TysonAndre committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    f9c142a View commit details
    Browse the repository at this point in the history

  4. Check return value of curl_multi_select

    @TysonAndre
    TysonAndre committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    34684b1 View commit details
    Browse the repository at this point in the history