Merge pull request #2221 from WordPress/feature/enqueuedresourceparam…

…s-bugfix WP/EnqueuedResourceParameters: fix handling of an edge case
WordPress · Apr 17, 2023 · 39ecc31 · 39ecc31
2 parents f3dac10 + 968ff8c
commit 39ecc31
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 0 deletions.
diff --git a/WordPress/Sniffs/WP/EnqueuedResourceParametersSniff.php b/WordPress/Sniffs/WP/EnqueuedResourceParametersSniff.php
@@ -135,6 +135,9 @@ public function process_parameters( $stackPtr, $group_name, $matched_content, $p
 		$error_ptr = $stackPtr;
 		if ( false !== $version_param ) {
 			$error_ptr = $this->phpcsFile->findNext( Tokens::$emptyTokens, $version_param['start'], ( $version_param['end'] + 1 ), true );
+			if ( false === $error_ptr ) {
+				$error_ptr = $version_param['start'];
+			}
 		}
 
 		if ( false === $version_param || 'null' === $version_param['clean'] ) {

diff --git a/WordPress/Tests/WP/EnqueuedResourceParametersUnitTest.inc b/WordPress/Tests/WP/EnqueuedResourceParametersUnitTest.inc
@@ -83,3 +83,6 @@ wp_register_script( 'someScript-js', $url, [], 0_0.0_0, true ); // Error - 0, fa
 
 // Safeguard handling of PHP 8.1 explicit octals.
 wp_register_script( 'someScript-js', $url, [], 0o0, true ); // Error - 0, false or NULL are not allowed.
+
+// Live coding/parse error.
+wp_register_style( src: 'https://example.com/someScript.js', ver: /*to do*/, handle: 'someScript-js', );
diff --git a/WordPress/Tests/WP/EnqueuedResourceParametersUnitTest.php b/WordPress/Tests/WP/EnqueuedResourceParametersUnitTest.php
@@ -39,6 +39,7 @@ public function getErrorList() {
 			61 => 1,
 			82 => 1,
 			85 => 1,
+			88 => 1,
 		);
 	}