Merge pull request #2324 from WordPress/feature/core-update-dirname-s…

…niff-handling
WordPress · Jul 26, 2023 · ca2da67 · ca2da67
2 parents 2c593e4 + 01d23a6
commit ca2da67
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/.phpcs.xml.dist b/.phpcs.xml.dist
@@ -50,6 +50,9 @@
 
 		<!-- Linting is done in a separate CI job, no need to duplicate it. -->
 		<exclude name="Generic.PHP.Syntax"/>
+
+		<!-- WPCS still has a PHP 5.4 minimum. -->
+		<exclude name="Modernize.FunctionCalls.Dirname"/>
 	</rule>
 
 	<!-- Check code for cross-version PHP compatibility. -->

diff --git a/WordPress-Core/ruleset.xml b/WordPress-Core/ruleset.xml
@@ -923,8 +923,9 @@
 	<!-- Check that class name references use the correct case. -->
 	<rule ref="WordPress.WP.ClassNameCase"/>
 
-	<!-- Check that __DIR__ is favoured over dirname(__FILE__).
+	<!-- Check that __DIR__ is favoured over dirname(__FILE__)
+		 and that dirname( __DIR__, $levels ) is favoured over nested calls to dirname().
 		 See: https://core.trac.wordpress.org/ticket/48082 -->
-	<rule ref="Modernize.FunctionCalls.Dirname.FileConstant"/>
+	<rule ref="Modernize.FunctionCalls.Dirname"/>
 
 </ruleset>
diff --git a/WordPress-Extra/ruleset.xml b/WordPress-Extra/ruleset.xml
@@ -5,6 +5,12 @@
 
 	<rule ref="WordPress-Core"/>
 
+	<!-- Silence the "no nested dirnames, use $levels" notice, which is included in Core,
+		 as plugin/themes may still support PHP < 7.0. -->
+	<rule ref="Modernize.FunctionCalls.Dirname.Nested">
+		<severity>0</severity>
+	</rule>
+
 	<!-- Generic PHP best practices.
 		 https://github.com/WordPress/WordPress-Coding-Standards/pull/382 -->
 	<rule ref="Generic.PHP.DeprecatedFunctions"/>