Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releasing 0.14.0 ? #1158

Closed
jrfnl opened this issue Sep 22, 2017 · 6 comments
Closed

Releasing 0.14.0 ? #1158

jrfnl opened this issue Sep 22, 2017 · 6 comments

Comments

@jrfnl
Copy link
Member

jrfnl commented Sep 22, 2017

Further on #1157, I would like to propose releasing WPCS 0.14.0 some time over the next two weeks.

The release as it is, is already quite feature rich: https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/milestone/14

I think it would be great if we could still get #1135 and #1136 over the finish line before then.

With #1157 in mind, I would like to propose leaving #1084 for a future release. /cc @GaryJones

As for #1041, this needs a new review and if nothing blocking comes up, it could ship with 0.14.0, otherwise this can be moved to a future release. /cc @emgk

Any objections ? If not, please leave feedback where feedback is requested. Thanks ❤️

@jrfnl jrfnl added this to the 0.14.0 milestone Sep 22, 2017
@GaryJones
Copy link
Member

I would like to propose leaving #1084 for a future release

Fine with me.

@jrfnl
Copy link
Member Author

jrfnl commented Sep 23, 2017

FYI: I've created a preliminary changelog and will keep updating it until we are ready to release.

Where this hadn't been done yet, I've updated the wiki pages with information about new (merged) sniff properties and whitelist flags.

I've also created PRs #1161 and #1162 to be in sync with the release.

@jrfnl jrfnl mentioned this issue Sep 23, 2017
5 tasks
@jrfnl
Copy link
Member Author

jrfnl commented Sep 26, 2017

I'm hoping to get clarification about a potential issue with the new PreparedSQLPlaceholders sniff before the release as it may need a fix to be more lenient about literal %'sses. See: #1160 (comment)
Fingers crossed this will be clarified soon.

@emgk
Copy link
Contributor

emgk commented Oct 4, 2017

As for #1041, this needs a new review and if nothing blocking comes up, it could ship with 0.14.0, otherwise this can be moved to a future release.

Please let me know if I need to make any changes. :)

@jrfnl
Copy link
Member Author

jrfnl commented Oct 5, 2017

@emgk Sorry about the delayed second review. I will try and have a look later today.

@pento Any chance of some feedback on #1135 and #1136 over the next week ?

@jrfnl
Copy link
Member Author

jrfnl commented Oct 9, 2017

Looks like we're nearly there.

I'm still working on an update to the PreparedSQLPlaceholders sniff which should go into this release. I should have that PR ready sometime this week.

Other than that #1163 is ready for merge and I will get to #1041 ;-)

@jrfnl jrfnl closed this as completed Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants