Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ValidHookNames: ignore deprecated hooks by design #1812

Open
jrfnl opened this issue Oct 15, 2019 · 1 comment
Open

ValidHookNames: ignore deprecated hooks by design #1812

jrfnl opened this issue Oct 15, 2019 · 1 comment
Labels
Type: Enhancement

Comments

@jrfnl
Copy link
Member

jrfnl commented Oct 15, 2019

Hooks which are marked as @deprecated should be ignored for the purposes of the ValidHookName sniff.

Related: #1797, #1806, #1811
@jrfnl jrfnl mentioned this issue Oct 15, 2019
Open
@jrfnl
Copy link
Member Author

jrfnl commented Oct 27, 2019 •
edited

Hard-deprecated hooks using apply_filters_deprecated() and do_action_deprecated() are currently already ignored by the sniff. It is only the "soft" deprecated hooks, i.e. hooks which have a @deprecated marker in the docblock, but don't use the above mentioned functions which are not (yet) ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrfnl