Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPCS 3.8.0: remove temporary test exclusion for fixer conflict check #2274

Closed
2 tasks
jrfnl opened this issue Jun 30, 2023 · 0 comments · Fixed by #2413
Closed
2 tasks

PHPCS 3.8.0: remove temporary test exclusion for fixer conflict check #2274

jrfnl opened this issue Jun 30, 2023 · 0 comments · Fixed by #2413
Milestone

Comments

@jrfnl
Copy link
Member

jrfnl commented Jun 30, 2023

Rationale

PR #2243 adds a temporary exclusion to the fixer conflict check related to an upstream sniff.

Once the upstream PHPCS sniff has been fixed (PR is open), that exclusion should be removed again.

Note: in the mean time, it is unlikely this issue will cause problems for real-life code as the problem involves a PHP compile error.

References

Action Checklist

Once a PHPCS version is available which handles this correctly...

  • Update the minimum supported PHPCS version in composer.json and update the README and workflows etc.
  • Remove the test exception from the fixer conflict check in the GH Actions workflow.
@jrfnl jrfnl added Upstream: PHPCS Status: Requirement not met On hold until WPCS supports a particular version of a dependency (PHP, PHP_CodeSniffer, etc.). labels Jun 30, 2023
@jrfnl jrfnl removed the Status: Requirement not met On hold until WPCS supports a particular version of a dependency (PHP, PHP_CodeSniffer, etc.). label Dec 8, 2023
@jrfnl jrfnl changed the title PHPCS 3.?.?: remove temporary test exclusion for fixer conflict check PHPCS 3.8.0: remove temporary test exclusion for fixer conflict check Dec 8, 2023
@jrfnl jrfnl added this to the 3.1.0 milestone Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant