Skip to content

Commit

Permalink
Post Formats: You have to pass an array of supported post formats.
Browse files Browse the repository at this point in the history
This shows a `_doing_it_wrong()` message and also returns false instead of true if no array of formats is passed in `add_theme_support()`, avoiding a PHP error.

Post formats maintainership comes full circle. 🙃

Props Mista-Flo, sproutchris, garrett-eclipse.
Fixes #51390.

Built from https://develop.svn.wordpress.org/trunk@49344


git-svn-id: http://core.svn.wordpress.org/trunk@49104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  • Loading branch information
helen committed Oct 27, 2020
1 parent 7636806 commit 3fc623c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions wp-includes/theme.php
Expand Up @@ -2481,6 +2481,7 @@ function get_theme_starter_content() {
* by adding it to the function signature.
* @since 5.5.0 The `core-block-patterns` feature was added and is enabled by default.
* @since 5.5.0 The `custom-logo` feature now also accepts 'unlink-homepage-logo'.
* @since 5.6.0 The `post-formats` feature now returns doing it wrong if no array is passed
*
* @global array $_wp_theme_features
*
Expand Down Expand Up @@ -2523,6 +2524,9 @@ function add_theme_support( $feature, ...$args ) {
unset( $post_formats['standard'] );

$args[0] = array_intersect( $args[0], array_keys( $post_formats ) );
} else {
_doing_it_wrong( "add_theme_support( 'post-formats' )", __( 'You need to pass an array of types.' ), '5.6.0' );
return false;
}
break;

Expand Down
2 changes: 1 addition & 1 deletion wp-includes/version.php
Expand Up @@ -13,7 +13,7 @@
*
* @global string $wp_version
*/
$wp_version = '5.6-beta1-49343';
$wp_version = '5.6-beta1-49344';

/**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.
Expand Down

0 comments on commit 3fc623c

Please sign in to comment.