Skip to content

Commit

Permalink
Revert type="email" (HTML5) as some browsers that do validation on th…
Browse files Browse the repository at this point in the history
…ese fields do not work for IDN domains yet. Core does not support these well either, but server-side validation can at least be dealt with by a plugin. see #17863.

git-svn-id: http://svn.automattic.com/wordpress/trunk@20196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  • Loading branch information
nacin committed Mar 15, 2012
1 parent 0fdd30d commit 8c841df
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion wp-admin/edit-form-comment.php
Expand Up @@ -92,7 +92,7 @@
_e( 'E-mail:' );
}
?></td>
<td><input type="email" name="newcomment_author_email" size="30" value="<?php echo $comment->comment_author_email; ?>" tabindex="2" id="email" /></td>
<td><input type="text" name="newcomment_author_email" size="30" value="<?php echo $comment->comment_author_email; ?>" tabindex="2" id="email" /></td>
</tr>
<tr valign="top">
<td class="first">
Expand Down
2 changes: 1 addition & 1 deletion wp-admin/includes/template.php
Expand Up @@ -323,7 +323,7 @@ function wp_comment_reply($position = '1', $checkbox = false, $mode = 'single',

<div class="inside">
<label for="author-email"><?php _e('E-mail') ?></label>
<input type="email" name="newcomment_author_email" size="50" value="" tabindex="102" id="author-email" />
<input type="text" name="newcomment_author_email" size="50" value="" tabindex="102" id="author-email" />
</div>

<div class="inside">
Expand Down
2 changes: 1 addition & 1 deletion wp-admin/network/site-users.php
Expand Up @@ -300,7 +300,7 @@
</tr>
<tr>
<th scope="row"><?php _e( 'Email' ) ?></th>
<td><input type="email" class="regular-text" name="user[email]" /></td>
<td><input type="text" class="regular-text" name="user[email]" /></td>
</tr>
<tr>
<th scope="row"><?php _e( 'Role'); ?></th>
Expand Down
4 changes: 2 additions & 2 deletions wp-admin/options-general.php
Expand Up @@ -113,7 +113,7 @@ function add_js() {
</tr>
<tr valign="top">
<th scope="row"><label for="admin_email"><?php _e('E-mail Address') ?> </label></th>
<td><input name="admin_email" type="email" id="admin_email" value="<?php form_option('admin_email'); ?>" class="regular-text ltr" />
<td><input name="admin_email" type="text" id="admin_email" value="<?php form_option('admin_email'); ?>" class="regular-text ltr" />
<span class="description"><?php _e('This address is used for admin purposes, like new user notification.') ?></span></td>
</tr>
<tr valign="top">
Expand All @@ -132,7 +132,7 @@ function add_js() {
<?php } else { ?>
<tr valign="top">
<th scope="row"><label for="new_admin_email"><?php _e('E-mail Address') ?> </label></th>
<td><input name="new_admin_email" type="email" id="new_admin_email" value="<?php form_option('admin_email'); ?>" class="regular-text ltr" />
<td><input name="new_admin_email" type="text" id="new_admin_email" value="<?php form_option('admin_email'); ?>" class="regular-text ltr" />
<span class="description"><?php _e('This address is used for admin purposes. If you change this we will send you an e-mail at your new address to confirm it. <strong>The new address will not become active until confirmed.</strong>') ?></span>
<?php
$new_admin_email = get_option( 'new_admin_email' );
Expand Down
2 changes: 1 addition & 1 deletion wp-admin/user-edit.php
Expand Up @@ -333,7 +333,7 @@ function use_ssl_preference($user) {
<table class="form-table">
<tr>
<th><label for="email"><?php _e('E-mail'); ?> <span class="description"><?php _e('(required)'); ?></span></label></th>
<td><input type="email" name="email" id="email" value="<?php echo esc_attr($profileuser->user_email) ?>" class="regular-text" />
<td><input type="text" name="email" id="email" value="<?php echo esc_attr($profileuser->user_email) ?>" class="regular-text" />
<?php
$new_email = get_option( $current_user->ID . '_new_email' );
if ( $new_email && $new_email != $current_user->user_email ) : ?>
Expand Down

0 comments on commit 8c841df

Please sign in to comment.