Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket #31248 on WordPress Trac #125

Closed
wants to merge 2 commits into from
Closed

Conversation

tfrommen
Copy link
Member

@tfrommen tfrommen commented Feb 6, 2015

Originally, I just wanted to replace the missing short description of the get_inline_data function with the comment directly placed above the PHPDoc block. But then I fixed several other things that either my IDE complained about or that I just saw while plowing through the code.

Applying the attached patch does the following:

  • add short description to get_inline_data function;
  • replace default value '1' of int variable $position in wp_comment_reply function with 1;
  • replace empty return; statements for _list_meta_row function with @return string PHPDoc comment with return '';;
  • replace default value false of string variable $selected in wp_dropdown_roles function with '';
  • replace loose comparison with strict string comparison in wp_dropdown_roles function;
  • remove unused (last!) argument $limit_styles in iframe_header function (as well as the according PHPDoc comment);
  • remove unused globalization of $current_user variable in iframe_header function;
  • add missing @return string PHPDoc comment for get_submit_button function;
  • replace default values null of string variable $text and array variable $other_attribues in get_submit_button function with appropriate values (i.e., '' and array());
  • add missing @param PHPDoc comments for enqueue_scripts and dismiss_pointers_for_new_users functions.

This mirrors ticket #31248 on WordPress Trac.

@tfrommen tfrommen changed the title See ticket https://core.trac.wordpress.org/ticket/31248 Ticket #31248 on WordPress Trac Feb 6, 2015
@tfrommen tfrommen closed this Feb 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant