This repository has been archived by the owner on Jul 28, 2023. It is now read-only.
Hydrate views even if they are registered after the DOM nodes appear #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbravobernal
approved these changes
Aug 25, 2022
DAreRodz
approved these changes
Aug 25, 2022
Comment on lines
+13
to
+15
| ['wp', 'view', name].reduce((obj, name, i) => { | ||
| if (typeof obj[name] === 'undefined') | ||
| obj[name] = i === 2 ? initialValue : {}; |
There was a problem hiding this comment.
Interesting way to initialize a nested property inside an undefined object. 🙂
I would use the length from the array instead of hardcoding it to check if we have reached the property with the initial value:
Suggested change
| ['wp', 'view', name].reduce((obj, name, i) => { | |
| if (typeof obj[name] === 'undefined') | |
| obj[name] = i === 2 ? initialValue : {}; | |
| ['wp', 'view', name].reduce((obj, name, i, array) => { | |
| if (typeof obj[name] === 'undefined') | |
| obj[name] = i === (array.length - 1) ? initialValue : {}; |
There was a problem hiding this comment.
Yeah, but why calculate array.length - 1 when it is always 2 anyway. And if someone changes the array length in the future and doesn't update the hardcoded value, this thing won't work at all. So I think it's fine with the hardcoded 2 😄🤷♂️
There was a problem hiding this comment.
I'm going to merge this as it is, but feel free to refute my argument!
luisherranz
deleted the
register-block-type-and-connected-callback-execution-order
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@DAreRodz and I did a pair programming this morning that resulted in this PR to fix #52.
What
We changed the logic to make sure there are no race conditions between the
Viewcomponents being registered and the custom elements'connectedCallbackexecution.Why
Because sometimes the registration will happen after the
connectedCallbackexecution.How
Create a global registry that can be accessed by any party, and delay the hydration of the custom elements that have no
Viewcomponent registered yet.https://www.loom.com/share/e01d077aa2c74bf5a0b59a606dee28dc
Additional comments
I've also renamed
registerBlockTypetoregisterBlockViewas an alternative to #56 and removed all references to the word "frontend", even in file names.cc: @c4rl0sbr4v0: would you mind taking a look at that? Thanks!