This repository has been archived by the owner on Jul 28, 2023. It is now read-only.
⚛️ Get rid of the <wp-block> wrapper
#72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAreRodz
commented
Sep 21, 2022
luisherranz
approved these changes
Sep 21, 2022
There was a problem hiding this comment.
Looks great to me. Looking forward to the day we have the WP_HTML_Walker available for these HTML injections 🙂
It may be worth noting that this would only work if we enforce blocks to have a single node wrapper. Maybe we need to add that to the requirements in the README.
Added in 110dcbf. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
<wp-block>wrapper and, instead, appends all wp block attributes to the element's attributes whereblockPropsare rendered.The technique is a bit hacky because:
save, as most of the required information is not availablegrep_replace(), using a RegExp that could not be reliable enough.