🎨 Add wp-link attribute to all links

[SantosGuillamot]

I'm opening this Pull Request to "Add the wp-link to all the relative links on the page", one of the tasks of the Tracking issue: WordPress Directives Plugin. This PR aims to just add that attribute in PHP, while all the logic will be handled within the directives in JS.

The first idea is to handle that in the render_block filter using the WP_HTML_Tag_Processor.

[SantosGuillamot]

So far, I just added a single filter, but I encountered two problems:

• If there are two links in the same block, the wp-link attribute is only added to the first element. For example, a paragraph with two links:

<p>First Link: <a wp-link="true" href="/">First Link</a>. Second Link: <a href="/sample-page">Second Link</a>.</p>

• It seems to be working fine with the current navigation block. But I quickly tested it with the Experimental Navigation block using directives and it doesn't seem to apply.

I haven't triaged it yet, but any ideas why this is happening or how to solve it are welcome 🙂

[luisherranz]

Oh, sorry. The HTML Tag Processor needs to be called recursively:

$w = new WP_HTML_Walker( $html );
while ( $w->next_tag("a") ) {
  // ...
}

By the way, I've just noticed that in one of the examples of the Make Core post, they are using $w->get_attribute("sr"). Maybe it's already implemented. Could you please check it out?

[SantosGuillamot]

The HTML Tag Processor needs to be called recursively

That makes sense 😄 I've just changed it.

By the way, I've just noticed that in one of the examples of the Make Core post, they are using $w->get_attribute("sr"). Maybe it's already implemented. Could you please check it out?

Yes, it seems implemented! 🙂 I added a check for the hostname and another one to exit the loop if target === 'blank'. Any more use cases where we shouldn't add the wp-link attribute?

I will try to take a look now at why this isn't working in the navigation block using directives.

[luisherranz]

Any more use cases where we shouldn't add the wp-link attribute?

We can add more later if we need to 🙂

[luisherranz]

Looks good to me, Mario!

[SantosGuillamot]

Thanks for the review! Changes addressed 🙂