Skip to content
This repository has been archived by the owner on Jul 28, 2023. It is now read-only.

馃帹 Preserve client components in the DOM #89

Merged
merged 1 commit into from
Oct 21, 2022
Merged

馃帹 Preserve client components in the DOM #89

merged 1 commit into from
Oct 21, 2022

Conversation

luisherranz
Copy link
Member

This is a small fix to preserve client components in the DOM because we were inadvertently deleting them until now.

https://www.loom.com/share/56f6c98eb47c4d9a91c6f6816512ce9e

@luisherranz luisherranz self-assigned this Oct 21, 2022
@luisherranz luisherranz changed the base branch from main-custom-elements-hydration to main-wp-directives-plugin October 21, 2022 09:27
@luisherranz luisherranz mentioned this pull request Oct 21, 2022
Closed
23 tasks
SantosGuillamot
SantosGuillamot approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@SantosGuillamot SantosGuillamot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 馃檪

@luisherranz
Copy link
Member Author

Thanks, Mario! 馃檪

@luisherranz luisherranz merged commit aee404f into main-wp-directives-plugin Oct 21, 2022
@luisherranz luisherranz deleted the preserve-client-components-in-the-dom branch October 21, 2022 14:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SantosGuillamot SantosGuillamot SantosGuillamot approved these changes

@DAreRodz DAreRodz Awaiting requested review from DAreRodz

Assignees

@luisherranz luisherranz

Labels
馃帹 WordPress Directives Plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@luisherranz @SantosGuillamot