Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix zip compatibility issue #94

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Fix zip compatibility issue #94

merged 1 commit into from
Mar 28, 2024

Conversation

reimic
Copy link
Collaborator

@reimic reimic commented Mar 27, 2024

What does this PR do?

  • UnzipStepRunner tests will now pass for all supported PHP versions
  • some variables in the test were renamed for better readability and to match linting standards

What problem does it fix?

  • the ZipCentralDirectoryEntry and ZipFileEntry had some code that was PHP == 7.0 incompatible
  • some tests for the UnzipStepRunner were commented out since it broke the pipeline for PHP == 7.0

How to test if it works?

  • this PR includes tests for UnzipStepRunner
  • all tests should pass for all supported PHP versions

@reimic reimic self-assigned this Mar 27, 2024
@reimic reimic mentioned this pull request Mar 27, 2024
Open
@adamziel adamziel merged commit 410c88d into WordPress:trunk Mar 28, 2024
27 checks passed
@reimic reimic deleted the fix-zip-compat branch March 28, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@reimic reimic

Labels
PHP 7 Compatibility Steps tests V1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@reimic @adamziel