Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up RmStepRunner and its tests #95

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

reimic
Copy link
Collaborator

@reimic reimic commented Mar 27, 2024

What does this PR do?

  • removes the try / catch block from the RmStepRunner
  • renames some variables in the test class for better readability and to match linting standards

What problem does it fix?

How to test if it works?

  • this PR includes tests for RmStepRunner
  • all tests should pass for all supported PHP versions

 - the runner won't catch IOExceptions
 - some variables in the test were renamed for better readability and to match linting standards
@reimic reimic self-assigned this Mar 27, 2024
@adamziel adamziel merged commit 425106c into WordPress:trunk Mar 28, 2024
27 checks passed
@reimic reimic deleted the rmstep branch March 28, 2024 11:13
@reimic reimic restored the rmstep branch April 4, 2024 15:42
@reimic reimic deleted the rmstep branch April 4, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants