Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to previews for theme changes using playground #162

Merged
merged 9 commits into from
Apr 15, 2024

Conversation

MaggieCabrera
Copy link
Collaborator

@MaggieCabrera MaggieCabrera commented Apr 15, 2024

This PR blatantly copies the implementation in the Automattic themes repo (Automattic/themes#7719). Thank you @vcanales for this, it will work nicely for community themes as well.

This introduces a Github action that runs on pull requests and adds a link to preview the changes using Playground. I made changes to Atlas and Poetry, and the links can be seen on this same PR.

@MaggieCabrera MaggieCabrera marked this pull request as ready for review April 15, 2024 09:18
@MaggieCabrera MaggieCabrera self-assigned this Apr 15, 2024
@MaggieCabrera MaggieCabrera added the enhancement New feature or request label Apr 15, 2024
Copy link
Member

@vcanales vcanales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

.github/workflows/preview-theme.yml Outdated Show resolved Hide resolved
MaggieCabrera and others added 2 commits April 15, 2024 17:30
Co-authored-by: Vicente Canales <1157901+vcanales@users.noreply.github.com>
@MaggieCabrera
Copy link
Collaborator Author

MaggieCabrera commented Apr 15, 2024

@vcanales when I removed the theme changes it failed, hehe

looks like exit 78 makes the fail check, when it should pass

@MaggieCabrera MaggieCabrera merged commit c099a5a into trunk Apr 15, 2024
1 check passed
@vcanales vcanales deleted the add-playground-workflows branch May 6, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants