Fixed a few null ref bugs

WordPress · Mar 22, 2024 · c18c22c · c18c22c
1 parent 7235e27
commit c18c22c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/admin/create-theme/theme-create.php b/admin/create-theme/theme-create.php
@@ -101,6 +101,9 @@ public static function create_blank_theme( $theme, $screenshot ) {
 	}
 
 	private static function is_valid_screenshot( $file ) {
+		if ( ! $file ) {
+			return 0;
+		}
 		$filetype = wp_check_filetype( $file['name'], self::ALLOWED_SCREENSHOT_TYPES );
 		if ( is_uploaded_file( $file['tmp_name'] ) && in_array( $filetype['type'], self::ALLOWED_SCREENSHOT_TYPES, true ) && $file['size'] < 2097152 ) {
 			return 1;

diff --git a/includes/class-create-block-theme-api.php b/includes/class-create-block-theme-api.php
@@ -301,7 +301,7 @@ private function sanitize_theme_data( $theme ) {
 		$sanitized_theme['recommended_plugins'] = sanitize_textarea_field( $theme['recommended_plugins'] );
 		$sanitized_theme['template']            = '';
 		$sanitized_theme['slug']                = Theme_Utils::get_theme_slug( $theme['name'] );
-		$sanitized_theme['text_domain']         = $theme['slug'];
+		$sanitized_theme['text_domain']         = $sanitized_theme['slug'];
 		return $sanitized_theme;
 	}
 }
diff --git a/tests/test-theme-fonts.php b/tests/test-theme-fonts.php
@@ -123,6 +123,7 @@ private function create_blank_theme() {
 		$request->set_param( 'author_uri', '' );
 		$request->set_param( 'tags_custom', '' );
 		$request->set_param( 'subfolder', '' );
+		$request->set_param( 'recommended_plugins', '' );
 
 		rest_do_request( $request );