New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace dash icon with SVG icon #506

Merged

mikachan merged 1 commit into WordPress:trunk from t-hamano:replace-dashicon-width-svg-icon

Jan 15, 2024

Contributor

t-hamano commented Jan 14, 2024

Before	After

It was suggested that dashicons strings be deprecated from the Icon component: Icon: Deprecate dashicon strings gutenberg#43725
SVG icons are cleaner and should match the @wordpress/components based UI.


          Replace dash icon with SVG icon

973a463

mikachan approved these changes

View reviewed changes

Member

mikachan left a comment

LGTM. Thank you!

mikachan merged commit 23ad9a5 into WordPress:trunk

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment