Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files and directories not needed for release to .distignore #512

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

t-hamano
Copy link
Contributor

I noticed that this plugin published in the plugin directory has .wp-env.json file.

https://plugins.trac.wordpress.org/browser/create-block-theme/trunk

image

I believe this is unnecessary for published plugins.

@vcanales
Copy link
Member

Agreed. Should we also add test/ for good measure?

@t-hamano t-hamano changed the title Add .wp-env.json to .distignore Add files and directories not needed for release to .distignore Feb 1, 2024
@t-hamano
Copy link
Contributor Author

t-hamano commented Feb 1, 2024

Should we also add test/ for good measure?

Makes sense. I also added vendor/ directory. Composer is not used in the current deploy action, but this is to prevent vendor directory from being unintentionally released if it is introduced in the future.

Copy link
Member

@vcanales vcanales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@vcanales vcanales merged commit 402d67f into WordPress:trunk Feb 1, 2024
1 check passed
@t-hamano t-hamano deleted the distignore-wp-env-json branch February 1, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants