Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add theme json inspector #520

Merged
merged 10 commits into from Apr 5, 2024
Merged

Add theme json inspector #520

merged 10 commits into from Apr 5, 2024

Conversation

vcanales
Copy link
Member

@vcanales vcanales commented Mar 15, 2024 •
edited

Add a code editor to enable viewing theme json data for the current theme.

Tasks:

  • Add a code editor.
    - [ ] Add instructions, including information on how to use the editor.
    - [ ] Enable writing JSON file to theme.

@pbking pbking linked an issue Mar 19, 2024 that may be closed by this pull request
Add a theme.json editor #491
Closed
@mikachan mikachan mentioned this pull request Mar 28, 2024
Closed
@vcanales vcanales marked this pull request as ready for review April 5, 2024 14:09
@vcanales vcanales changed the title Add theme json editor Add theme json inspector Apr 5, 2024
mikachan
mikachan reviewed Apr 5, 2024
View reviewed changes
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks so much for working on it! 🎉 It provides a good first step for revealing the whole theme.json contents without needing to open a separate code editor, and I'm looking forward to hearing feedback from users.

src/editor-sidebar/json-editor-modal.js Show resolved Hide resolved
src/plugin-sidebar.js Outdated Show resolved Hide resolved
vcanales and others added 2 commits April 5, 2024 12:35
@vcanales @mikachan
Update src/plugin-sidebar.js
200fb5b 
Co-authored-by: Sarah Norris <1645628+mikachan@users.noreply.github.com>
@vcanales @mikachan
Update src/editor-sidebar/json-editor-modal.js
fa5512b 
Co-authored-by: Sarah Norris <1645628+mikachan@users.noreply.github.com>
@vcanales vcanales merged commit 0f961ef into trunk Apr 5, 2024
2 checks passed
@vcanales vcanales deleted the add/theme-json-editor branch April 5, 2024 16:02
@jeffikus
Copy link
Contributor

jeffikus commented Apr 8, 2024

Oh this is awesome! Will give this a test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikachan mikachan mikachan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a theme.json editor
4 participants
@vcanales @jeffikus @mikachan @pbking