Add/child theme creation #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With #522 approved, I'm holding until that's merged to test this PR. |
pbking
force-pushed
the
add/child-theme-creation
branch
from
fc15a85
to
277b398
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does what it says on the tin.
To Test:
Make changes to your theme using the Site Editor. (Do not persist them to your theme with CBT). Changes should include style changes and template changes.
Export a Child Theme using the new interface
Review the contents of the child theme. ONLY the CHANGED Global Styles values should be in the theme.json file. Only templates that have been changed should be included.
Create a Child Theme using the new interface
Ensure that the created child theme is automatically activated
Review the contents of the child theme. ONLY the CHANGED Global Styles values should be in the theme.json file. Only templates that have been changed should be included.
Fixes: #530
Should not be merged until #522 lands